[CASSANDRA-6912] SSTableReader.isReplaced does not allow for safe resource cleanup

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 2.1 beta2
• Severity: Normal
• Since Version: 2.1 beta1
• Assignee: Benedict Elliott Smith
• Reporter: Benedict Elliott Smith

Authors

Benedict Elliott Smith

Reviewers

Tom Hobbs

• Created: 24/Mar/14 09:49
• Updated: 16/Apr/19 09:31
• Resolved: 04/Apr/14 20:40

Description

There are a number of possible race conditions on resource cleanup from the use of cloneWithNewSummarySamplingLevel, because the replacement sstable can be itself replaced/obsoleted while the prior sstable is still referenced (this is actually quite easy with compaction, but can happen in other circumstances less commonly).

Issue Links

• breaks: CASSANDRA-7000 Assertion in SSTableReader during repair.
• is depended upon by: CASSANDRA-6916 Preemptive opening of compaction result
• is depended upon by: CASSANDRA-6919 Use OpOrder to guard sstable references for reads, instead of acquiring/releasing references