[CASSANDRA-6652] Stop CommitLogSegment.close() from unnecessarily calling sync() prior to cleaning the buffer

• Type: Improvement
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 2.0.6
• Assignee: Benedict Elliott Smith
• Reporter: Benedict Elliott Smith

Authors

Benedict Elliott Smith

Reviewers

Marcus Eriksson

• Created: 05/Feb/14 10:28
• Updated: 16/Apr/19 09:31
• Resolved: 11/Feb/14 08:24

Description

What it says on the tin. Currently CLS.close() calls sync() before cleaning the buffer, which may result in unnecessary IO, but also in the case of a failure on the commit disk may prevent CLS from being discarded, or in the case of a faulty file may prevent any progress on reclaiming CLS.

Issue Links

• is required by: CASSANDRA-6364 There should be different disk_failure_policies for data and commit volumes or commit volume failure should always cause node exit