Details

    • Type: New Feature New Feature
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Fix Version/s: 1.2.11, 2.0.2
    • Component/s: Core
    • Labels:

      Description

      There are an increasing amount of use cases where ONE is desirable, but cross-DC traffic is not. LOCAL_ONE would solves this by reading at ONE, but only within the DC the coordinator is in.

      1. 6202_2.0-v2.diff
        16 kB
        Jason Brown
      2. 6202_1.2-v2.diff
        28 kB
        Jason Brown
      3. 6202-v1.diff
        12 kB
        Jason Brown

        Activity

        Hide
        Jason Brown added a comment -

        Attached v1 adds LOCAL_ONE as a new consistency level. Two notes:

        • I hand-added it to o.a.c.thrift.ConsistencyLevel as it was a surgically small change and I'm hoping we don't need to regenerate all the thrift classes. I did add it to the cassandra.thrift interface, though, in case we need to regenerate now or in the future.
        • cqlsh won't work without adding CL.LOCAL_ONE to it. I have a modified version locally, and if this patch is approved, I'll work to get cassandra-dbapi2 updated, released, and dropped into the c* lib directory.
        Show
        Jason Brown added a comment - Attached v1 adds LOCAL_ONE as a new consistency level. Two notes: I hand-added it to o.a.c.thrift.ConsistencyLevel as it was a surgically small change and I'm hoping we don't need to regenerate all the thrift classes. I did add it to the cassandra.thrift interface, though, in case we need to regenerate now or in the future. cqlsh won't work without adding CL.LOCAL_ONE to it. I have a modified version locally, and if this patch is approved, I'll work to get cassandra-dbapi2 updated, released, and dropped into the c* lib directory.
        Hide
        Brandon Williams added a comment -

        A few quick notes from eyeballing it:

        • cassandra.thrift version needs to be bumped. To be safe, I think we need to regenerate.
        • cql3 doc needs to be updated.
        • probably ought to add a unit test, since I'm not sure how we could easily detect a cross-dc read in a dtest.
        Show
        Brandon Williams added a comment - A few quick notes from eyeballing it: cassandra.thrift version needs to be bumped. To be safe, I think we need to regenerate. cql3 doc needs to be updated. probably ought to add a unit test, since I'm not sure how we could easily detect a cross-dc read in a dtest.
        Hide
        Jason Brown added a comment -

        attached v2 for both 1.2 and 2.0 branches. Need two patches mainly due to generated thrift files being different between the branches.

        Show
        Jason Brown added a comment - attached v2 for both 1.2 and 2.0 branches. Need two patches mainly due to generated thrift files being different between the branches.
        Hide
        Jonathan Ellis added a comment -

        +1

        Show
        Jonathan Ellis added a comment - +1
        Hide
        Jason Brown added a comment - - edited
        Show
        Jason Brown added a comment - - edited changes to lib/cql-internal-only.zip found here: https://code.google.com/a/apache-extras.org/p/cassandra-dbapi2/issues/detail?id=53
        Hide
        Jason Brown added a comment -

        committed to 1.2, 2.0, and trunk

        Show
        Jason Brown added a comment - committed to 1.2, 2.0, and trunk

          People

          • Assignee:
            Jason Brown
            Reporter:
            Brandon Williams
            Reviewer:
            Jonathan Ellis
          • Votes:
            0 Vote for this issue
            Watchers:
            5 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development