Cassandra
  1. Cassandra
  2. CASSANDRA-6197

Create more Pig unit tests for type mappings

    Details

    • Type: Test Test
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Fix Version/s: 1.2.11, 2.0.2
    • Component/s: Hadoop
    • Labels:
      None

      Description

      We need add more Pig unit testing for data type mappings including collections

      1. 6197-1.2-branch.txt
        36 kB
        Alex Liu
      2. 6179-v2.txt
        36 kB
        Alex Liu

        Activity

        Hide
        Alex Liu added a comment -

        6197-1.2-branch.txt patch is on cassandra-1.2. It also fixes the issue of collection data types with decimal and InetAddress types as element types

        Show
        Alex Liu added a comment - 6197-1.2-branch.txt patch is on cassandra-1.2. It also fixes the issue of collection data types with decimal and InetAddress types as element types
        Hide
        Brandon Williams added a comment -

        I'm seeing this failure when running the tests:

            [junit] Testcase: testCassandraStorageSchema(org.apache.cassandra.pig.ThriftColumnFamilyDataTypeTest):      FAILED
            [junit] expected:<1296691200000> but was:<1296709200000>
            [junit] junit.framework.AssertionFailedError: expected:<1296691200000> but was:<1296709200000>
            [junit]     at org.apache.cassandra.pig.ThriftColumnFamilyDataTypeTest.testCassandraStorageSchema(ThriftColumnFamilyDataTypeTest.java:139)
        

        I couldn't tell where this is coming from with a quick glance, but on that note it would probably be better to have the statement order match the sort/test order so it's not so hard to match things up when something fails.

        Show
        Brandon Williams added a comment - I'm seeing this failure when running the tests: [junit] Testcase: testCassandraStorageSchema(org.apache.cassandra.pig.ThriftColumnFamilyDataTypeTest): FAILED [junit] expected:<1296691200000> but was:<1296709200000> [junit] junit.framework.AssertionFailedError: expected:<1296691200000> but was:<1296709200000> [junit] at org.apache.cassandra.pig.ThriftColumnFamilyDataTypeTest.testCassandraStorageSchema(ThriftColumnFamilyDataTypeTest.java:139) I couldn't tell where this is coming from with a quick glance, but on that note it would probably be better to have the statement order match the sort/test order so it's not so hard to match things up when something fails.
        Hide
        Alex Liu added a comment -

        Sure, I will change it. The error comes from the date data which is sensitive to the time zone. I am fixing it.

        Show
        Alex Liu added a comment - Sure, I will change it. The error comes from the date data which is sensitive to the time zone. I am fixing it.
        Hide
        Alex Liu added a comment -

        6179-v2.txt fixes the date time zone bug and change the order of statements to sync with the result order.

        Show
        Alex Liu added a comment - 6179-v2.txt fixes the date time zone bug and change the order of statements to sync with the result order.
        Hide
        Brandon Williams added a comment -

        Committed.

        Show
        Brandon Williams added a comment - Committed.

          People

          • Assignee:
            Alex Liu
            Reporter:
            Alex Liu
            Reviewer:
            Brandon Williams
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development