[CASSANDRA-5662] Wasted work in StorageService.initClient()

• Type: Task
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 1.2.6
• Labels: performance

Environment

any

• Assignee: Adrian Nistor
• Reporter: Adrian Nistor

Authors

Adrian Nistor

Reviewers

Jonathan Ellis

• Created: 19/Jun/13 14:31
• Updated: 16/Apr/19 09:32
• Resolved: 19/Jun/13 21:32

Description

The problem appears in version 1.2.5 and in revision 26018be2.. I
attached a one-line patch that fixes it.

In method "StorageService.initClient", the loop over
"Gossiper.instance.getLiveMembers()" should break immediately after
"isUp" is set to "true". All the iterations after "isUp" is set to
"true" do not perform any useful work, at best they just set "isUp"
again to "true".

Method "getCompactedRow" in class "ParallelCompactionIterable.Reducer"
has a similar loop (over "rows"), and this loop breaks immediately
after "inMemory" is set to "false", just like in the proposed patch.
Other methods (e.g., "GroupByPrefix.count",
"SecondaryIndex.buildIndexAsync") also have similar loops with similar
breaks, just like in the proposed patch.