[CASSANDRA-5496] Fix SemanticVersion.isSupportedBy patch/minor handling

• Type: Bug
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 1.2.5
• Severity: Low
• Assignee: Aleksey Yeschenko
• Reporter: Aleksey Yeschenko

Authors

Aleksey Yeschenko

Reviewers

Jonathan Ellis

• Created: 18/Apr/13 16:32
• Updated: 16/Apr/19 09:32
• Resolved: 18/Apr/13 16:48

Description

Currently we use the following logic:

return major == version.major && minor <= version.minor && patch <= version.patch;

This requires both minor and patch vers to be less or equal, which means that, for example, '3.0.3' is not supported by '3.1.2', because, while 0 <= 1 (minor), 3 > 2 (patch). This is clearly not the intent since 3.1.2 > 3.0.3.

CQL3 doc: "Minor version increments occur when new, but backward compatible, functionality is introduced". Hence '3.0.3' is supposed to be supported by '3.1.0'.

This doesn't really affect 1.2, but breaks a lot of trunk dtests post CASSANDRA-3919.