Cassandra
  1. Cassandra
  2. CASSANDRA-5280

Provide a nodetool command to repair subranges

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Fix Version/s: 1.1.11, 1.2.3
    • Component/s: None
    • Labels:
      None

      Description

      Provide a nodetool command to run repairs for subranges

      It appears that the machinery to do this is already present and can be run through JMX

      StorageService:
      public AntiEntropyService.RepairFuture forceTableRepair(final Range<Token> range, final String tableName, boolean isSequential, final String... columnFamilies)

      1. 5280-v2.txt
        10 kB
        Brandon Williams
      2. 0001-fix-getNeighbors.patch
        1 kB
        Yuki Morishita
      3. 5280.txt
        8 kB
        Brandon Williams

        Activity

        Hide
        Brandon Williams added a comment -

        Patch adds the needed options to nodetool, however it looks like something is wrong with repairing specific ranges. Passing start/end that aren't token boundaries results in the node saying there are no neighbors to repair with, but passing tokens on the boundary does work.

        Show
        Brandon Williams added a comment - Patch adds the needed options to nodetool, however it looks like something is wrong with repairing specific ranges. Passing start/end that aren't token boundaries results in the node saying there are no neighbors to repair with, but passing tokens on the boundary does work.
        Hide
        Yuki Morishita added a comment -

        Patch lgtm, +1.
        Also attaching patch to fix subrange problem.

        Show
        Yuki Morishita added a comment - Patch lgtm, +1. Also attaching patch to fix subrange problem.
        Hide
        Brandon Williams added a comment -

        v2 incorporates the getNeighbors fix, and also catches the IAE and returns an error if the range crosses nodes.

        Show
        Brandon Williams added a comment - v2 incorporates the getNeighbors fix, and also catches the IAE and returns an error if the range crosses nodes.
        Hide
        Yuki Morishita added a comment -

        +1

        Show
        Yuki Morishita added a comment - +1
        Hide
        Brandon Williams added a comment -

        Committed.

        Show
        Brandon Williams added a comment - Committed.

          People

          • Assignee:
            Brandon Williams
            Reporter:
            Ahmed Bashir
            Reviewer:
            Yuki Morishita
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development