Cassandra
  1. Cassandra
  2. CASSANDRA-5172

Detect (and warn) unintentional use of the cql2 thrift methods when cql3 was the intention

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Fix Version/s: 1.2.1
    • Component/s: None
    • Labels:
      None

      Description

      In 1.2.0 we've separated the thrift methods for CQL2 and CQL3 (due to CASSANDRA-4734). In doing so, we've made set_cql_version a silent no-op.

      However it means that the 1.1 way of querying CQL3 now silently end up calling CQL2 in 1.2.0. So I suggest that if someone calls set_cql_version, we record the version set and warn if (throw an invalid exception) if someone asks for CQL3 but later use the CQL2 methods.

      1. 5172.txt
        2 kB
        Sylvain Lebresne
      2. 5172-2.txt
        6 kB
        Sylvain Lebresne

        Issue Links

          Activity

          Gavin made changes -
          Workflow patch-available, re-open possible [ 12753824 ] reopen-resolved, no closed status, patch-avail, testing [ 12759007 ]
          Gavin made changes -
          Workflow no-reopen-closed, patch-avail [ 12746630 ] patch-available, re-open possible [ 12753824 ]
          Sylvain Lebresne made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Resolution Fixed [ 1 ]
          Sylvain Lebresne made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Reviewer jbellis
          Sylvain Lebresne made changes -
          Attachment 5172-2.txt [ 12565797 ]
          Sylvain Lebresne made changes -
          Link This issue is duplicated by CASSANDRA-5177 [ CASSANDRA-5177 ]
          Sylvain Lebresne made changes -
          Field Original Value New Value
          Attachment 5172.txt [ 12565484 ]
          Sylvain Lebresne created issue -

            People

            • Assignee:
              Sylvain Lebresne
              Reporter:
              Sylvain Lebresne
              Reviewer:
              Jonathan Ellis
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development