Cassandra
  1. Cassandra
  2. CASSANDRA-4994

cassandra.yaml - actually separate server_encryption_options and client_encryption_options

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Fix Version/s: 1.2.0 beta 3
    • Component/s: None
    • Labels:
      None

      Description

      Currently they have different names but use the same option names, which doesn't make sense for two reasons:

      • internode_encryption: none/all doesn't make sense for client encryption. Should be 'enabled: true/false'
      • truststore and truststore_password are not used by Cassandra for client encryption and shouldn't be present in client_encryption_options.

      Moved type-dependent options to either ServerEncryptionOptions or ClientEncryptionOptions. Left truststore and truststore_password in EncryptionOptions for use by Stress and CLI (but removed them from cassandra.yaml).

      1. 4994.txt
        12 kB
        Aleksey Yeschenko

        Activity

        Hide
        Jonathan Ellis added a comment -

        Can you review Vijay?

        Show
        Jonathan Ellis added a comment - Can you review Vijay ?
        Hide
        Vijay added a comment -

        Hi Jonathan will do,

        LGTM, committed with minor nit (made EncryptionOptions to abstract).

        Show
        Vijay added a comment - Hi Jonathan will do, LGTM, committed with minor nit (made EncryptionOptions to abstract).
        Hide
        Vijay added a comment -

        Hi Alex, sorry i didnt realize that you could commit... Anyways committed!

        Show
        Vijay added a comment - Hi Alex, sorry i didnt realize that you could commit... Anyways committed!
        Hide
        Aleksey Yeschenko added a comment -

        np Vijay, thanks for reviewing (and committing too).

        Show
        Aleksey Yeschenko added a comment - np Vijay, thanks for reviewing (and committing too).

          People

          • Assignee:
            Aleksey Yeschenko
            Reporter:
            Aleksey Yeschenko
            Reviewer:
            Vijay
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development