Details

    • Type: Improvement
    • Status: Resolved
    • Priority: Major
    • Resolution: Duplicate
    • Fix Version/s: None
    • Component/s: None
    • Labels:
      None
    1. cass-thrift09.txt
      1.28 MB
      Radim Kolar
    2. libthrift-0.9.0.jar
      339 kB
      Radim Kolar
    3. thrift-python-internal-only-0.9.0.zip
      38 kB
      Radim Kolar

      Activity

      Hide
      jbellis Jonathan Ellis added a comment -

      see CASSANDRA-3719. (planning to upgrade thrift after we branch 1.2.)

      Show
      jbellis Jonathan Ellis added a comment - see CASSANDRA-3719 . (planning to upgrade thrift after we branch 1.2.)
      Hide
      hsn Radim Kolar added a comment -

      Thrift you are using has known memory leaks, some are fixed in 0.9. Can you explain benefits for end user to have intentionally delivered software with memory leaks?

      Show
      hsn Radim Kolar added a comment - Thrift you are using has known memory leaks, some are fixed in 0.9. Can you explain benefits for end user to have intentionally delivered software with memory leaks?
      Hide
      jbellis Jonathan Ellis added a comment -

      If you care to link to the memory leak fixes we can evaluate whether the risk of upgrading to an untested Thrift late in the dev cyle is worth it.

      Show
      jbellis Jonathan Ellis added a comment - If you care to link to the memory leak fixes we can evaluate whether the risk of upgrading to an untested Thrift late in the dev cyle is worth it.
      Hide
      hsn Radim Kolar added a comment -

      There are no memory leak fixes committed to github after 0.9.0 was released. Closer inspection of thrift changelog shows that memory leaks fixed in 0.8 and 0.9 are not related to java server, but to C/C++. Interesting fix is THRIFT-1457 for shrinking memory buffers.

      Show
      hsn Radim Kolar added a comment - There are no memory leak fixes committed to github after 0.9.0 was released. Closer inspection of thrift changelog shows that memory leaks fixed in 0.8 and 0.9 are not related to java server, but to C/C++. Interesting fix is THRIFT-1457 for shrinking memory buffers.
      Hide
      jbellis Jonathan Ellis added a comment -

      Unless Jira is out of date, THRIFT-1457 is not fixed in 0.9 either.

      Show
      jbellis Jonathan Ellis added a comment - Unless Jira is out of date, THRIFT-1457 is not fixed in 0.9 either.
      Hide
      hsn Radim Kolar added a comment -

      its not but since patch is trivial and you ship thrift library binary with cassandra, you can ship a patched one.

      Show
      hsn Radim Kolar added a comment - its not but since patch is trivial and you ship thrift library binary with cassandra, you can ship a patched one.

        People

        • Assignee:
          Unassigned
          Reporter:
          hsn Radim Kolar
        • Votes:
          0 Vote for this issue
          Watchers:
          1 Start watching this issue

          Dates

          • Created:
            Updated:
            Resolved:

            Development