[CASSANDRA-4763] SSTableLoader shouldn't get keyspace from path

• Type: Improvement
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 4.0-alpha3, 4.0
• Component/s: Legacy/Tools
• Assignee: Eduard Tudenhoefner
• Reporter: Nick Bailey

Authors

Eduard Tudenhoefner

Reviewers

Brandon Williams

• Created: 04/Oct/12 16:39
• Updated: 15/May/20 08:38
• Resolved: 29/Jan/20 19:59

Description

SSTableLoader currently gets the keyspace it is going to load to from the path of the directoy of sstables it is loading. This isn't really documented (or I didn't see it), but also isn't really a good way of doing it in general.

this.keyspace = directory.getParentFile().getName();

We should probably just let users pass the name in. If you are loading a snapshot the file names will have the keyspace which is slightly better but people manually creating their own sstables might not format them the same.

Issue Links

• is superceded by: CASSANDRA-13884 sstableloader option to accept target keyspace name