Cassandra
  1. Cassandra
  2. CASSANDRA-4213

DynamicEndpointSnitch calculates score incorrectly

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Fix Version/s: 1.2.0 beta 1
    • Component/s: Core
    • Labels:
      None

      Description

      updateScore does double = long/long math which calculates the score wrong 1/3 becomes 0.0 not 0.3333

      need 1 to be cast to double

        Activity

        Hide
        Dave Brosius added a comment -

        against trunk

        Show
        Dave Brosius added a comment - against trunk
        Hide
        Jonathan Ellis added a comment -

        Any reason not to put this in 1.0 and 1.1 branches?

        Show
        Jonathan Ellis added a comment - Any reason not to put this in 1.0 and 1.1 branches?
        Show
        Dave Brosius added a comment - I believe this code is new http://git-wip-us.apache.org/repos/asf?p=cassandra.git;a=blobdiff;f=src/java/org/apache/cassandra/locator/DynamicEndpointSnitch.java;h=b0249169601add3e9e222348cfbbc9722676cf39;hp=3b80e67ccc52f6de9e1172a974a8faf490bce3c3;hb=0cc97d91c0cf92cd8476b5a5d0bdf7d3d66a45fc;hpb=5b4a7f29980621a162fdc202a17bd3300c20e298
        Hide
        Jonathan Ellis added a comment -

        ah, got it. marking affects: 1.2

        Show
        Jonathan Ellis added a comment - ah, got it. marking affects: 1.2
        Hide
        Brandon Williams added a comment -

        Committed, thanks!

        Show
        Brandon Williams added a comment - Committed, thanks!

          People

          • Assignee:
            Dave Brosius
            Reporter:
            Dave Brosius
            Reviewer:
            Brandon Williams
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development