Cassandra
  1. Cassandra
  2. CASSANDRA-4213

DynamicEndpointSnitch calculates score incorrectly

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Trivial Trivial
    • Resolution: Fixed
    • Fix Version/s: 1.2.0 beta 1
    • Component/s: None
    • Labels:
      None

      Description

      updateScore does double = long/long math which calculates the score wrong 1/3 becomes 0.0 not 0.3333

      need 1 to be cast to double

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        22h 39m 1 Dave Brosius 04/May/12 01:39
        Patch Available Patch Available Resolved Resolved
        16h 27m 1 Brandon Williams 04/May/12 18:07
        Aleksey Yeschenko made changes -
        Component/s Core [ 12312978 ]
        Gavin made changes -
        Workflow patch-available, re-open possible [ 12749645 ] reopen-resolved, no closed status, patch-avail, testing [ 12754345 ]
        Gavin made changes -
        Workflow no-reopen-closed, patch-avail [ 12665215 ] patch-available, re-open possible [ 12749645 ]
        Brandon Williams made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Hide
        Brandon Williams added a comment -

        Committed, thanks!

        Show
        Brandon Williams added a comment - Committed, thanks!
        Jonathan Ellis made changes -
        Assignee Brandon Williams [ brandon.williams ] Dave Brosius [ dbrosius ]
        Reviewer brandon.williams
        Jonathan Ellis made changes -
        Affects Version/s 1.2 [ 12319262 ]
        Hide
        Jonathan Ellis added a comment -

        ah, got it. marking affects: 1.2

        Show
        Jonathan Ellis added a comment - ah, got it. marking affects: 1.2
        Show
        Dave Brosius added a comment - I believe this code is new http://git-wip-us.apache.org/repos/asf?p=cassandra.git;a=blobdiff;f=src/java/org/apache/cassandra/locator/DynamicEndpointSnitch.java;h=b0249169601add3e9e222348cfbbc9722676cf39;hp=3b80e67ccc52f6de9e1172a974a8faf490bce3c3;hb=0cc97d91c0cf92cd8476b5a5d0bdf7d3d66a45fc;hpb=5b4a7f29980621a162fdc202a17bd3300c20e298
        Hide
        Jonathan Ellis added a comment -

        Any reason not to put this in 1.0 and 1.1 branches?

        Show
        Jonathan Ellis added a comment - Any reason not to put this in 1.0 and 1.1 branches?
        Dave Brosius made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Dave Brosius made changes -
        Attachment 4213_use_double_math.diff [ 12525547 ]
        Hide
        Dave Brosius added a comment -

        against trunk

        Show
        Dave Brosius added a comment - against trunk
        Brandon Williams made changes -
        Fix Version/s 1.2 [ 12319262 ]
        Affects Version/s 1.0.9 [ 12319856 ]
        Brandon Williams made changes -
        Field Original Value New Value
        Assignee Brandon Williams [ brandon.williams ]
        Dave Brosius created issue -

          People

          • Assignee:
            Dave Brosius
            Reporter:
            Dave Brosius
            Reviewer:
            Brandon Williams
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development