Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Fix Version/s: 1.1.1
    • Component/s: API
    • Labels:

      Description

      The goal of this ticket is to be the home for a number of minor fixes/improvements in CQL3 that I didn't felt warranted a ticket each. It includes 4 patches:

      • The first one fixes the grammar for float constants, so as to not recognize 3.-3, but to actually allow 3. (i.e, with radix point but with the fractional part left blank)
      • The second one correctly detect the (invalid) case where a table is created with COMPACT STORAGE but without any 'clustering keys'.
      • The third one fixes COUNT, first by making sure both COUNT and COUNT(1) are correctly recognized and also by "processing" the internal row before counting, are there isn't a 1-to-1 correspondence between internal rows and CQL rows in CQL3. The grammar change in this patch actually rely on CASSANDRA-4184
      • The fourth and last patch disallows the counter type for keys (i.e. any column part of the PRIMARY KEY) as it is completely non-sensical and will only led to confusion.
      1. 0004-Disallow-counters-for-PRIMARY-KEY-part-v2.txt
        10 kB
        Sylvain Lebresne
      2. 0003-Fix-COUNT-in-select.txt
        5 kB
        Sylvain Lebresne
      3. 0002-Fix-compact-storage-validation.txt
        1 kB
        Sylvain Lebresne
      4. 0001-Fix-float-parsing.txt
        0.7 kB
        Sylvain Lebresne

        Issue Links

          Activity

          Sylvain Lebresne created issue -
          Sylvain Lebresne made changes -
          Field Original Value New Value
          Attachment 0001-Fix-float-parsing.txt [ 12524265 ]
          Attachment 0002-Fix-compact-storage-validation.txt [ 12524266 ]
          Attachment 0003-Fix-COUNT-in-select.txt [ 12524267 ]
          Attachment 0004-Disallow-counters-for-PRIMARY-KEY-part.txt [ 12524268 ]
          Sylvain Lebresne made changes -
          Status Open [ 1 ] Patch Available [ 10002 ]
          Sylvain Lebresne made changes -
          Link This issue depends on CASSANDRA-4184 [ CASSANDRA-4184 ]
          Sylvain Lebresne made changes -
          Attachment 0004-Disallow-counters-for-PRIMARY-KEY-part.txt [ 12524268 ]
          Hide
          Sylvain Lebresne added a comment -

          Realized the last patch was missing some parts. v2 attached with those missing parts.

          Show
          Sylvain Lebresne added a comment - Realized the last patch was missing some parts. v2 attached with those missing parts.
          Sylvain Lebresne made changes -
          Hide
          Jonathan Ellis added a comment -

          +1

          Show
          Jonathan Ellis added a comment - +1
          Hide
          Sylvain Lebresne added a comment -

          Committed, thanks

          Show
          Sylvain Lebresne added a comment - Committed, thanks
          Sylvain Lebresne made changes -
          Status Patch Available [ 10002 ] Resolved [ 5 ]
          Reviewer jbellis
          Resolution Fixed [ 1 ]
          Gavin made changes -
          Workflow no-reopen-closed, patch-avail [ 12664160 ] patch-available, re-open possible [ 12749644 ]
          Gavin made changes -
          Workflow patch-available, re-open possible [ 12749644 ] reopen-resolved, no closed status, patch-avail, testing [ 12754344 ]
          Gavin made changes -
          Link This issue depends on CASSANDRA-4184 [ CASSANDRA-4184 ]
          Gavin made changes -
          Link This issue depends upon CASSANDRA-4184 [ CASSANDRA-4184 ]
          Transition Time In Source Status Execution Times Last Executer Last Execution Date
          Open Open Patch Available Patch Available
          27s 1 Sylvain Lebresne 25/Apr/12 14:08
          Patch Available Patch Available Resolved Resolved
          7d 18h 21m 1 Sylvain Lebresne 03/May/12 08:30

            People

            • Assignee:
              Sylvain Lebresne
              Reporter:
              Sylvain Lebresne
              Reviewer:
              Jonathan Ellis
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development