Cassandra
  1. Cassandra
  2. CASSANDRA-3803

snapshot-before-compaction snapshots entire keyspace

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Fix Version/s: 1.0.8, 1.1.0
    • Component/s: Core
    • Labels:

      Description

      Should only snapshot the CF being compacted

      1. 3803.txt
        2 kB
        Jonathan Ellis

        Activity

        Hide
        Jonathan Ellis added a comment -

        I can't think of a good reason to snapshot the entire keyspace, and doing so can dramatically increase the space needed to enable snapshot_before_compaction.

        Show
        Jonathan Ellis added a comment - I can't think of a good reason to snapshot the entire keyspace, and doing so can dramatically increase the space needed to enable snapshot_before_compaction.
        Hide
        Sylvain Lebresne added a comment -

        I think the attached patch is the wrong one.

        Show
        Sylvain Lebresne added a comment - I think the attached patch is the wrong one.
        Hide
        Jonathan Ellis added a comment -

        2nd try. Also switches to snapshot-without-flush.

        Show
        Jonathan Ellis added a comment - 2nd try. Also switches to snapshot-without-flush.
        Hide
        Sylvain Lebresne added a comment -

        +1, but I would actually suggest pushing this in 1.0.8. The fact we were flushing all CFs on each compaction is pretty bad (not sure anyone actually uses snapshot-before-compaction but still).

        Show
        Sylvain Lebresne added a comment - +1, but I would actually suggest pushing this in 1.0.8. The fact we were flushing all CFs on each compaction is pretty bad (not sure anyone actually uses snapshot-before-compaction but still).
        Hide
        Sylvain Lebresne added a comment -

        As a side not, a nice alternative would be to snapshot only the files we're going to compact. But again, we probably don't care about that feature that much.

        Show
        Sylvain Lebresne added a comment - As a side not, a nice alternative would be to snapshot only the files we're going to compact. But again, we probably don't care about that feature that much.
        Hide
        Jonathan Ellis added a comment - - edited

        committed to 1.0.8 + 1.1

        Show
        Jonathan Ellis added a comment - - edited committed to 1.0.8 + 1.1

          People

          • Assignee:
            Jonathan Ellis
            Reporter:
            Jonathan Ellis
            Reviewer:
            Sylvain Lebresne
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development