[CASSANDRA-3569] Failure detector downs should not break streams

• Type: New Feature
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 2.1.1
• Component/s: Legacy/Streaming and Messaging
• Assignee: Joshua McKenzie Assign to me
• Reporter: Peter Schuller

Authors

Joshua McKenzie

Reviewers

Marcus Eriksson

• Created: 04/Dec/11 00:55
• Updated: 16/Apr/19 09:32
• Resolved: 03/Jun/14 06:15

Description

CASSANDRA-2433 introduced this behavior just to get repairs to don't sit there waiting forever. In my opinion the correct fix to that problem is to use TCP keep alive. Unfortunately the TCP keep alive period is insanely high by default on a modern Linux, so just doing that is not entirely good either.

But using the failure detector seems non-sensicle to me. We have a communication method which is the TCP transport, that we know is used for long-running processes that you don't want to incorrectly be killed for no good reason, and we are using a failure detector tuned to detecting when not to send real-time sensitive request to nodes in order to actively kill a working connection.

So, rather than add complexity with protocol based ping/pongs and such, I propose that we simply just use TCP keep alive for streaming connections and instruct operators of production clusters to tweak net.ipv4.tcp_keepalive_

{probes,intvl}

as appropriate (or whatever equivalent on their OS).

I can submit the patch. Awaiting opinions.

Issue Links

• is duplicated by: CASSANDRA-7262 During streaming: java.lang.AssertionError: Reference counter -1
• is related to: CASSANDRA-3838 Repair Streaming hangs between multiple regions
• is related to: CASSANDRA-7063 Raise the streaming phi threshold check in 1.2