Cassandra
  1. Cassandra
  2. CASSANDRA-3476

Allow user to override jvm options picked by cassandra-env.sh

    Details

    • Type: Improvement Improvement
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Fix Version/s: 1.1.0
    • Component/s: None
    • Labels:

      Description

      currently user have $JVM_OPTS - they are used before automagically generated ops.

      1. patch-env
        0.4 kB
        Radim Kolar
      2. 3476.patch.txt
        0.6 kB
        paul cannon

        Activity

        Transition Time In Source Status Execution Times Last Executer Last Execution Date
        Open Open Patch Available Patch Available
        2m 42s 1 Radim Kolar 09/Nov/11 16:06
        Patch Available Patch Available Resolved Resolved
        31d 2h 45m 1 Jonathan Ellis 10/Dec/11 18:51
        Gavin made changes -
        Workflow patch-available, re-open possible [ 12749137 ] reopen-resolved, no closed status, patch-avail, testing [ 12754069 ]
        Gavin made changes -
        Workflow no-reopen-closed, patch-avail [ 12641607 ] patch-available, re-open possible [ 12749137 ]
        Hide
        Hudson added a comment -

        Integrated in Cassandra #1251 (See https://builds.apache.org/job/Cassandra/1251/)
        add support for JVM_EXTRA_OPTS env variable to cassandra-env.sh
        patch by Radim Kolar; reviewed by Paul Cannon for CASSANDRA-3476

        jbellis : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212843
        Files :

        • /cassandra/trunk/conf/cassandra-env.sh
        Show
        Hudson added a comment - Integrated in Cassandra #1251 (See https://builds.apache.org/job/Cassandra/1251/ ) add support for JVM_EXTRA_OPTS env variable to cassandra-env.sh patch by Radim Kolar; reviewed by Paul Cannon for CASSANDRA-3476 jbellis : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1212843 Files : /cassandra/trunk/conf/cassandra-env.sh
        Jonathan Ellis made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Fix Version/s 1.1 [ 12317615 ]
        Fix Version/s 1.0.6 [ 12319161 ]
        Resolution Fixed [ 1 ]
        Hide
        Jonathan Ellis added a comment -

        committed

        Show
        Jonathan Ellis added a comment - committed
        Hide
        paul cannon added a comment -

        +1

        Show
        paul cannon added a comment - +1
        paul cannon made changes -
        Attachment 3476.patch.txt [ 12506852 ]
        Hide
        paul cannon added a comment -

        Adjusted patch according to my last comment.

        Show
        paul cannon added a comment - Adjusted patch according to my last comment.
        Sylvain Lebresne made changes -
        Fix Version/s 1.0.6 [ 12319161 ]
        Fix Version/s 1.0.5 [ 12319144 ]
        Sylvain Lebresne made changes -
        Fix Version/s 1.0.5 [ 12319144 ]
        Fix Version/s 1.0.4 [ 12319064 ]
        Hide
        paul cannon added a comment -

        +1, although as a nitpick I'd prefer the variable be named JVM_EXTRA_OPTS instead of JVM_OVERRIDE_OPTS, since its value won't actually override the other JVM_OPTS.

        Show
        paul cannon added a comment - +1, although as a nitpick I'd prefer the variable be named JVM_EXTRA_OPTS instead of JVM_OVERRIDE_OPTS , since its value won't actually override the other JVM_OPTS .
        Sylvain Lebresne made changes -
        Fix Version/s 1.0.4 [ 12319064 ]
        Fix Version/s 1.0.3 [ 12318940 ]
        Jonathan Ellis made changes -
        Assignee Radim Kolar [ hsn ]
        Fix Version/s 1.0.3 [ 12318940 ]
        Affects Version/s 1.0.2 [ 12318740 ]
        Reviewer thepaul
        Radim Kolar made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Hide
        Radim Kolar added a comment -

        patch attached

        Show
        Radim Kolar added a comment - patch attached
        Radim Kolar made changes -
        Field Original Value New Value
        Attachment patch-env [ 12503095 ]
        Radim Kolar created issue -

          People

          • Assignee:
            Radim Kolar
            Reporter:
            Radim Kolar
            Reviewer:
            paul cannon
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development