[CASSANDRA-3462] Determine IP address of Message sender from the socket, rather than trusting the sender

• Type: Sub-task
• Status: Resolved
• Priority: Normal
• Resolution: Not A Problem
• Fix Version/s: 1.0.3
• Labels: authentication security

Environment

All.

• Assignee: Unassigned
• Reporter: David Allsopp

Reviewers

Brandon Williams

• Created: 07/Nov/11 10:54
• Updated: 16/Apr/19 09:32
• Resolved: 08/Nov/11 13:03

Description

A prerequisite for preventing malicious nodes from joining a cluster (parent issue https://issues.apache.org/jira/browse/CASSANDRA-2274) is that we can determine the IP of the sender (setting aside the fact that this may be spoofed by a determined attacker).

Currently we deserialize the "from" IP address from the incoming message header, using Header.deserialize() and CompactEndpointSerializationHelper.deserialize() i.e. we trust the sender to supply a true IP address.

We could stop storing the IP address in the message Header at all (saving a small amount of space) and set the 'true' sender IP upon receipt of the message, in org.apache.cassandra.net.IncomingTcpConnection, using socket.getInetAddress().