[CASSANDRA-3390] ReadResponseSerializer.serializedSize() calculation is wrong

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 0.8.8, 1.0.1
• Severity: Normal
• Assignee: Jonathan Ellis
• Reporter: Yang Yang

Authors

Jonathan Ellis

Reviewers

Sylvain Lebresne

• Created: 20/Oct/11 19:44
• Updated: 16/Apr/19 09:32
• Resolved: 24/Oct/11 20:24

Description

in ReadResponse.java

the following code

public long serializedSize(ReadResponse response, int version)

{ int size = DBConstants.intSize; size += (response.isDigestQuery() ? response.digest() : ByteBufferUtil.EMPTY_BYTE_BUFFER).remaining(); size += DBConstants.boolSize; if (response.isDigestQuery()) size += response.digest().remaining(); else size += Row.serializer().serializedSize(response.row(), version); return size; }

adds the digest size 2 times

this triggers assertion error in at least ReadVerbHandler