[CASSANDRA-3388] StorageService.setMode() is used inconsistently

• Type: Bug
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 1.0.2
• Severity: Low
• Assignee: Sylvain Lebresne
• Reporter: Tom Hobbs

Authors

Sylvain Lebresne

Reviewers

Tom Hobbs

• Created: 19/Oct/11 22:45
• Updated: 16/Apr/19 09:32
• Resolved: 28/Oct/11 17:23

Description

StorageService.setMode(), which ends up setting the OperationMode attribute of the related mbean, is used inconsistently. In most places, it's used like "setMode("MODE: details"), but in a few places, it's used more like a normal log message.

To make this attribute more usable through JMX, setMode() should have a signature like setMode(mode, details), where the mode parameter could be an enum (or even just a string, the main thing is just being consistent). The OperationMode JMX attribute should definitely remain a string, though.