Uploaded image for project: 'Cassandra'
  1. Cassandra
  2. CASSANDRA-3388

StorageService.setMode() is used inconsistently

Agile BoardAttach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskConvert to sub-taskMoveLinkCloneLabelsUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Low
    • Resolution: Fixed
    • Fix Version/s: 1.0.2
    • Component/s: None
    • Labels:
      None
    • Severity:
      Low

      Description

      StorageService.setMode(), which ends up setting the OperationMode attribute of the related mbean, is used inconsistently. In most places, it's used like "setMode("MODE: details"), but in a few places, it's used more like a normal log message.

      To make this attribute more usable through JMX, setMode() should have a signature like setMode(mode, details), where the mode parameter could be an enum (or even just a string, the main thing is just being consistent). The OperationMode JMX attribute should definitely remain a string, though.

        Attachments

        1. 3388.patch
          3 kB
          Sylvain Lebresne
        2. 3388_v2.patch
          10 kB
          Sylvain Lebresne

          Activity

            People

            • Assignee:
              slebresne Sylvain Lebresne Assign to me
              Reporter:
              thobbs Tom Hobbs
              Authors:
              Sylvain Lebresne
              Reviewers:
              Tom Hobbs

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment