Uploaded image for project: 'Cassandra'
  1. Cassandra
  2. CASSANDRA-3303

Short reads protection results in returning more columns than asked for

Agile BoardAttach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskConvert to sub-taskMoveLinkCloneLabelsUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Resolved
    • Priority: Low
    • Resolution: Fixed
    • Fix Version/s: 1.0.2
    • Component/s: None
    • Labels:
      None
    • Severity:
      Low

      Description

      When we detect a short read (in SP.fetchRows), we retry a new command created by:

      logger.debug("detected short read: expected {} columns, but only resolved {} columns", sliceCommand.count, liveColumnsInRow);
      int retryCount = sliceCommand.count + sliceCommand.count - liveColumnsInRow;
      SliceFromReadCommand retryCommand = new SliceFromReadCommand(command.table,
                                                                   command.key,
                                                                   command.queryPath,
                                                                   sliceCommand.start,
                                                                   sliceCommand.finish,
                                                                   sliceCommand.reversed,
                                                                   retryCount);
      

      That is, in that new command, the count is greater than what asked in the initial command. But we never cut back the result of that new retried query.

        Attachments

        1. cassandra-3303-5.patch
          11 kB
          Byron Clark
        2. cassandra-3303-4.patch
          11 kB
          Byron Clark
        3. cassandra-3303-3.patch
          9 kB
          Byron Clark
        4. cassandra-3303-2.patch
          6 kB
          Byron Clark
        5. cassandra-3303-1.patch
          6 kB
          Byron Clark
        6. ASF.LICENSE.NOT.GRANTED--long_read.sh
          2 kB
          Byron Clark

          Activity

            People

            • Assignee:
              byronclark Byron Clark Assign to me
              Reporter:
              slebresne Sylvain Lebresne
              Authors:
              Byron Clark
              Reviewers:
              Sylvain Lebresne

              Dates

              • Created:
                Updated:
                Resolved:

                Issue deployment