Cassandra
  1. Cassandra
  2. CASSANDRA-2805

Clean up mbeans that return Internal Cassandra types

    Details

    • Type: Bug Bug
    • Status: Resolved
    • Priority: Minor Minor
    • Resolution: Fixed
    • Fix Version/s: 1.1.0
    • Component/s: None
    • Labels:

      Description

      We need to clean up wherever we return internal cassandra objects over jmx. Namely CompactionInfo objects as well as Tokens. There may be a few other examples.

      This is bad for two reasons

      1. You have to load the cassandra jar when querying these mbeans, which sucks.
      2. Stuff breaks between versions when things are moved. For example, CASSANDRA-1610 moves the compaction related classes around. Any code querying those jmx mbeans in 0.8.0 is now broken in 0.8.2. (assuming those moves stay in the 0.8 branch)

      For things like CompactionInfo we should just expose more mbean methods or serialize to something standard like json.

      I'd like to target this for 0.8.2. Since we've already broken compatibility between 0.8.0 and 0.8.1, I'd say just fix this everywhere now.

        Activity

        Gavin made changes -
        Workflow patch-available, re-open possible [ 12748803 ] reopen-resolved, no closed status, patch-avail, testing [ 12756641 ]
        Gavin made changes -
        Workflow no-reopen-closed, patch-avail [ 12617474 ] patch-available, re-open possible [ 12748803 ]
        Jonathan Ellis made changes -
        Status Patch Available [ 10002 ] Resolved [ 5 ]
        Resolution Fixed [ 1 ]
        Nick Bailey made changes -
        Yuki Morishita made changes -
        Reviewer yukim
        Nick Bailey made changes -
        Status Open [ 1 ] Patch Available [ 10002 ]
        Nick Bailey made changes -
        Nick Bailey made changes -
        Assignee Gaurav Sharma [ gauravsh ] Nick Bailey [ nickmbailey ]
        Sylvain Lebresne made changes -
        Fix Version/s 1.1 [ 12317615 ]
        Fix Version/s 1.0 [ 12316349 ]
        Jonathan Ellis made changes -
        Fix Version/s 1.0 [ 12316349 ]
        Fix Version/s 0.8.5 [ 12317588 ]
        Sylvain Lebresne made changes -
        Fix Version/s 0.8.5 [ 12317588 ]
        Fix Version/s 0.8.4 [ 12317551 ]
        Sylvain Lebresne made changes -
        Fix Version/s 0.8.4 [ 12317551 ]
        Fix Version/s 0.8.3 [ 12317246 ]
        Sylvain Lebresne made changes -
        Fix Version/s 0.8.3 [ 12317246 ]
        Fix Version/s 0.8.2 [ 12316645 ]
        Jonathan Ellis made changes -
        Assignee Gaurav Sharma [ gauravsh ]
        Jonathan Ellis made changes -
        Labels lhf
        Assignee Nick Bailey [ nickmbailey ]
        Nick Bailey made changes -
        Assignee Nick Bailey [ nickmbailey ]
        Nick Bailey made changes -
        Field Original Value New Value
        Description We need to clean up wherever we return internal cassandra objects over jmx. Namely CompactionInfo objects as well as Tokens. There may be a few other examples.

        This is bad for two reasons

        1. You have to load the cassandra jar when querying these mbeans, which sucks.
        2. Stuff breaks between versions when things are moved. For example, CASSANDRA-1610 moves the compaction related classes around. Any code querying those jmx mbeans in 0.8.0 is now broken in 0.8.1.

        For things like CompactionInfo we should just expose more mbean methods or serialize to something standard like json.

        I'd like to target this for 0.8.2. Since we've already broken compatibility between 0.8.0 and 0.8.1, I'd say just fix this everywhere now.
        We need to clean up wherever we return internal cassandra objects over jmx. Namely CompactionInfo objects as well as Tokens. There may be a few other examples.

        This is bad for two reasons

        1. You have to load the cassandra jar when querying these mbeans, which sucks.
        2. Stuff breaks between versions when things are moved. For example, CASSANDRA-1610 moves the compaction related classes around. Any code querying those jmx mbeans in 0.8.0 is now broken in 0.8.2. (assuming those moves stay in the 0.8 branch)

        For things like CompactionInfo we should just expose more mbean methods or serialize to something standard like json.

        I'd like to target this for 0.8.2. Since we've already broken compatibility between 0.8.0 and 0.8.1, I'd say just fix this everywhere now.
        Nick Bailey created issue -

          People

          • Assignee:
            Nick Bailey
            Reporter:
            Nick Bailey
            Reviewer:
            Yuki Morishita
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development