[CASSANDRA-19878] Filtering on clustering columns in reversed order with BETWEEN return invalid results

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 5.1
• Component/s: CQL/Interpreter
• Bug Category: Correctness - API / Semantic Implementation
• Severity: Normal
• Complexity: Normal
• Discovered By: Fuzz Test
• Platform: All
• Since Version: 5.1

Source Control Link

https://github.com/apache/cassandra/commit/c7e9048d4df9c0a5bb178c8388a13ad44f1cc0d2

Test and Documentation Plan

The patch add a unit test to cover the problem

• Assignee: Benjamin Lerer
• Reporter: Benjamin Lerer

Authors

Benjamin Lerer

Reviewers

Caleb Rackliffe

• Created: 29/Aug/24 14:06
• Updated: 04/Sep/24 20:02
• Resolved: 04/Sep/24 20:02

Description

As noted by maedhroz, filtering on clustering columns in reverser order do not work properly.

The problem can be reproduced using the following test:

@Test
public void testReverseAndBetweenMemtableFiltering()
{
    createTable("CREATE TABLE %s(p int, c int, c2 int, abbreviation ascii, PRIMARY KEY (p, c, c2)) WITH CLUSTERING ORDER BY (c DESC, c2 DESC)");

    execute("INSERT INTO %s(p, c, c2, abbreviation) VALUES (0, 1, 1, 'CA')");
    execute("INSERT INTO %s(p, c, c2, abbreviation) VALUES (0, 2, 2, 'MA')");
    execute("INSERT INTO %s(p, c, c2, abbreviation) VALUES (0, 3, 3, 'MA')");
    execute("INSERT INTO %s(p, c, c2, abbreviation) VALUES (0, 4, 4, 'TX')");

    ResultSet betweenRowsNet = executeNet("SELECT * FROM %s WHERE c2 BETWEEN 2 AND 3 ALLOW FILTERING");
    assertRowsNet(betweenRowsNet, row (0, 3, 3, "MA"), row (0, 2, 2, "MA")); // NO RESULTS?
}

The issue is due to the fact that the comparison performed in BETWEEN.isSatisfied ignore the ReversedType.

Issue Links

• links to: PR