[CASSANDRA-1814] validation is inefficient

• Type: Improvement
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 0.7.0 rc 3
• Assignee: Gary Dusbabek
• Reporter: Gary Dusbabek

Authors

Gary Dusbabek

Reviewers

Jonathan Ellis

• Created: 03/Dec/10 16:36
• Updated: 16/Apr/19 09:33
• Resolved: 09/Dec/10 14:51

Description

We do all validation by simply calling AbstractType.getString(). This generates garbage needlessly and has a lot of overhead.

A simpler interface would be to make AbstractType.validate abstract and have the child classes implement it in an intelligent and efficient way.

EDIT: Somewhat related: It looks like we're attempting to validate column names in ThriftValidation.validateColumns(). Is this intentional? Nevermind that part. I get it.