[CASSANDRA-18055] Nodetool Compact set the compaction type incorrectly

• Type: Bug
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 5.0-alpha1, 5.0
• Component/s: Local/Compaction, Tool/nodetool
• Bug Category: Correctness
• Severity: Low
• Complexity: Normal
• Discovered By: User Report
• Platform: All
• Since Version: NA

Source Control Link

https://github.com/apache/cassandra/commit/3f83396b76115a25b8189410c68775f87f31f8ac

Test and Documentation Plan

ut and dt

• Assignee: Maxwell Guo
• Reporter: Maxwell Guo

Authors

Maxwell Guo

Reviewers

Brandon Williams, Branimir Lambov

• Created: 16/Nov/22 16:01
• Updated: 12/Sep/23 13:02
• Resolved: 07/Dec/22 11:27

Description

When using nodetool compactionstats to see what does the c*'s compactions are doing ,the output has got a column named "compaction type", but It seem that major compaction and minor compaction 's type are all name Compaction, after read the code I found that may be the the MAJOR_COMPACTION OperationType is not setted into AbstractCompactionTask
at this method : CompactionStrategyManager -> getMaximalTasks .When we peform a major compact without any arguments we will got this execute path :

// Some comments here
Compact.java : probe.forceKeyspaceCompaction(splitOutput, keyspace, tableNames);
--->
 ColumnFamilyStore.java :  cfStore.forceMajorCompaction(splitOutput);
---> 
CompactionManager.java : submitMaximal(cfStore, gcBefore, splitOutput, OperationType.MAJOR_COMPACTION); 

Unfortunately OperationType.MAJOR_COMPACTION is not rightly setted.

see the picture on the right I perform a major compact , and on the left the compactionstats show the type is only Compaction ;
I think it is import for us to know wether the task is a major or a minor .