[CASSANDRA-17851] Add interim prioritization logic for CompactionTasks

• Type: Improvement
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 5.0-alpha1, 5.0
• Component/s: Local/Compaction
• Change Category: Operability
• Complexity: Challenging
• Platform: All

Source Control Link

https://gitbox.apache.org/repos/asf?p=cassandra.git;a=commit;h=377e114cb1459895423c292cb0bf7f921fd30e43

Test and Documentation Plan

Modifying testing to respect new compaction prioritization

• Assignee: Josh McKenzie Assign to me
• Reporter: Josh McKenzie

Authors

Josh McKenzie

Reviewers

Alex Petrov

• Created: 23/Aug/22 19:18
• Updated: 12/Sep/23 13:02
• Resolved: 07/Sep/22 16:54

Description

While ultimately we could serve to have a real scheduler and single entry point for compactions, for now some moderate progress seems in order. There are cases where, during expansions, you can end up in a state where you can't finish upgrading sstables as they keep getting aborted by Incremental Repair and other operations that ultimately should be lower priority and not have the ability to cancel these operations.

The idea here is that tasks like upgradestables and cleanup (and other tasks that have the same priority) will get serialised since markAllCompacting is synchronising on data, and higher priority tasks will be able to still cancel others via runWithCompactionsDisabled.

Issue Links

• fixes: CASSANDRA-17890 Support high PRIORITY thread pool for use trriged compaction