[CASSANDRA-17797] All system properties and environment variables should be accessed via the new CassandraRelevantProperties and CassandraRelevantEnv classes

• Type: Improvement
• Status: Resolved
• Priority: Low
• Resolution: Fixed
• Fix Version/s: 5.0-alpha1, 5.0
• Component/s: Local/Config
• Change Category: Code Clarity
• Complexity: Low Hanging Fruit
• Platform: All
• Impacts: None, Docs

Source Control Link

https://github.com/apache/cassandra/commit/f6509086483983176f82a4b72912927693b6e573

Test and Documentation Plan

The patch requires running all tests related to the CI part. 
Documentation is not required for now due to no new system properties were added.

• Assignee: Maxim Muzafarov
• Reporter: Ekaterina Dimitrova

Authors

Maxim Muzafarov

Reviewers

Jacek Lewandowski, Stefan Miklosovic

• Created: 03/Aug/22 20:30
• Updated: 12/Sep/23 13:02
• Resolved: 11/May/23 05:41

Description

Follow up ticket for CASSANDRA-15876 - 
"Always access system properties and environment variables via the new CassandraRelevantProperties and CassandraRelevantEnv classes"
As part of that ticket we moved to the two new classes only properties/variables that were currently listed in System Properties Virtual Table.
We have to move to those classes the rest of the properties around the code and start using those classes to access all of them. 

Additional information for newcomers:

You might want to start by getting acquainted with CassandraRelevantProperties and CassandraRelevantEnv classes. Also, you might want to check what changes were done and how the first batch was transferred to this new framework as part of  CASSANDRA-15876

We are interested into the properties accessed currently through getProperties around the code.

As part of CASSANDRA-15876 relevant unit tests were added (CassandraRelevantPropertiesTest). To verify the new patch we need to ensure that all tests Cassandra pass and also to think about potential update of the mentioned test class.

Issue Links

• relates to: CASSANDRA-15876 Accessors for SystemProperties
• relates to: CASSANDRA-18587 Align all system property names used by the project to use the 'cassandra' prefix
• links to: dev-list: Move system properties
• links to: GitHub Pull Request #2046