[CASSANDRA-17205] File leaks will not be be detected and released due to strong self-references in the tidier

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.1-alpha1, 4.1
• Component/s: Local/SSTable
• Bug Category: Code - Bug - Unclear Impact
• Severity: Normal
• Complexity: Normal
• Discovered By: Unit Test
• Platform: All
• Since Version: 3.0.0 rc1

Source Control Link

https://git-wip-us.apache.org/repos/asf?p=cassandra.git;a=commit;h=f4a2135c5ba442aafd27bb7c12c85b376d5a2b87

Test and Documentation Plan

No new testing or documentation needed; discovered by existing long-running testing

• Assignee: Josh McKenzie
• Reporter: Josh McKenzie

Authors

Josh McKenzie

Reviewers

Benedict Elliott Smith, Josh McKenzie

• Created: 14/Dec/21 17:16
• Updated: 27/May/22 19:25
• Resolved: 17/Dec/21 16:24

Description

LogTransaction.SSTableTidier holds a reference to a Tracker which holds references to both a ColumnFamilyStore and a View, both of which hold refs to SSTableReaders. As per the comment at the top of the SSTableTidier:

// must not retain a reference to the SSTableReader, else leak detection cannot kick in

We shouldn't hold a reference to the Tracker here; long running unit tests w/-Dcassandra.debugrefcount=true had this pop up.

ERROR [Strong-Reference-Leak-Detector:1] 2020-10-27T01:10:12,421 NoSpamLogger.java:97 - Strong self-ref loop detected