[CASSANDRA-17199] Provide summary of failed SessionInfo's in StreamResultFuture

• Type: Improvement
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 5.0-alpha1, 5.0
• Component/s: Observability/Logging
• Labels: AdventCalendar2021 lhf
• Change Category: Operability
• Complexity: Low Hanging Fruit
• Platform: All

Source Control Link

https://github.com/apache/cassandra/commit/4444721b6de555352bf0ac3ef7e36f94dc832f41

Test and Documentation Plan

Circle ci tests passing

• Assignee: Natnael Adere
• Reporter: Brendan Cicchi

Authors

Natnael Adere

Reviewers

David Capwell, Dinesh Joshi, Jon Meredith

• Created: 08/Dec/21 19:46
• Updated: 12/Sep/23 13:03
• Resolved: 24/Mar/23 23:10

Description

Currently, we warn about the presence of one or more failed sessions existing in the final state and then an operator/user traces back through the logs to find any failed streams for troubleshooting.

private synchronized void maybeComplete()
{
    if (finishedAllSessions())
    {
        StreamState finalState = getCurrentState();
        if (finalState.hasFailedSession())
        {
            logger.warn("[Stream #{}] Stream failed", planId);
            tryFailure(new StreamException(finalState, "Stream failed"));
        }
        else
        {
            logger.info("[Stream #{}] All sessions completed", planId);
            trySuccess(finalState);
        }
    }
} 

It would be helpful to log out a summary of the SessionInfo for each failed session since that should be accessible via the StreamState.

 

This can be especially helpful for longer streaming operations like bootstrap where the failure could have been a long time back and all recent streams leading up to the warning actually are successful.

 

Issue Links

• causes: CASSANDRA-18431 Cassandra doesn't start on JDK17