[CASSANDRA-17141] internode_send_buff_size_in_bytes and internode_recv_buff_size_in_bytes from cassandra.yaml

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0.2, 4.1-alpha1, 4.1
• Component/s: Build
• Bug Category: Correctness
• Severity: Normal
• Complexity: Normal
• Discovered By: User Report
• Platform: All
• Since Version: 4.0

Source Control Link

https://github.com/apache/cassandra/commit/44ace88585f2aefc322465ed6b6f6ad5bfd5bb34

Test and Documentation Plan

Patch 4.0	CI J8	CI J11
Patch trunk	CI J8	CI J11

• Assignee: Ekaterina Dimitrova
• Reporter: Ekaterina Dimitrova

Authors

Ekaterina Dimitrova

Reviewers

David Capwell, Ekaterina Dimitrova

• Created: 12/Nov/21 00:35
• Updated: 27/May/22 19:25
• Resolved: 16/Nov/21 20:11

Description

While working on CASSANDRA-17132 I found that in 4.0 internode_send_buff_size_in_bytes and internode_recv_buff_size_in_bytes were renamed to 

internode_socket_send_buffer_size_in_bytes and internode_socket_receive_buffer_size_in_bytes

but only internally, not in cassandra.yaml. In cassandra.yaml we still have the old names. 

Options I see:

• we decide that there is difference to be acknowledged so we just rename and announce the new parameters in NEWS.txt

• it is confirmed that just a rename was needed. Then do we want to add backward compatibility so that anyone who is still looking to start upgrade from 3 or 3.11 can directly go smoothly to 4.0.2 without breaking change? 

CC benedict , ifesdjeen and aleksey for your opinion what will be the right way to handle this issue.

 

Issue Links

• is related to: CASSANDRA-17132 Fix startup issue with internode_application_timeout_in_ms
• is related to: CASSANDRA-17160 Emit warnings for deprecated parameters (changed names) only once
• relates to: CASSANDRA-15234 Standardise config and JVM parameters