[CASSANDRA-17117] CQLSSTableWriter backwards compatibility fix for Date fields

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0.2, 4.1-alpha1, 4.1
• Component/s: Local/SSTable
• Bug Category: Code
• Severity: Low
• Complexity: Normal
• Discovered By: User Report
• Platform: All
• Since Version: 4.0.0

Source Control Link

https://github.com/apache/cassandra/commit/c96131035b309dcc8d716fb0a57ff9d46a8c5042

Test and Documentation Plan

Patches for 4.0 and trunk are attached - added an additional unit test to cover the backward-compatible and current cases to make sure both are still supported.

• Assignee: Doug Rohrer
• Reporter: Doug Rohrer

Authors

Doug Rohrer

Reviewers

Brandon Williams, Sam Tunnicliffe

• Created: 03/Nov/21 13:53
• Updated: 27/May/22 19:25
• Resolved: 05/Nov/21 08:27

Description

cassandra-all library consumers of the CQLSSTableWriter class cannot easily create an appropriate instance of the LocalDate class in order to write SSTables including dates, and the current implementation no longer accepts a int value as a valid input as previous versions of the class would - we used to use ((AbstractType)columnSpecification.type).decompose(value); in order to serialize the value, but now we use the type codec's .serialize method. Unfortunately, this doesn't work when the consumer can't easily create the type needed (serialize, in the case of dates, takes a LocalDate instance which is not easy to construct outside of Cassandra internal code).

This can be worked around by catching the resulting ClassCastException thrown from the serialize call and falling back to the older decompose implementation, which would maintain backwards-compatibility with other users of the CQLSSTableWriter in cases where they are passing integers for date fields, which used to work.