[CASSANDRA-17084] startup fails if directories do not exist

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.1-alpha1, 4.1
• Component/s: Local/Startup and Shutdown
• Bug Category: Availability
• Severity: Normal
• Complexity: Normal
• Discovered By: User Report
• Platform: All
• Since Version: NA

Source Control Link

https://github.com/apache/cassandra/commit/76f8333e9b9c89f029dd586273d5d42fdaf676dd

Test and Documentation Plan

Added test

• Assignee: Brandon Williams
• Reporter: Brandon Williams

Authors

Brandon Williams

Reviewers

Berenguer Blasi

• Created: 29/Oct/21 15:24
• Updated: 27/May/22 19:24
• Resolved: 14/Jan/22 17:56

Description

Prior to CASSANDRA-16926, having commitlog and data dirs defined that did not exist would be created on startup, but now we throw:

Exception (org.apache.cassandra.exceptions.ConfigurationException) encountered during startup: Unable check disk space in 'bin/../data/commitlog'. Perhaps the Cassandra user does not have the necessary permissions
org.apache.cassandra.exceptions.ConfigurationException: Unable check disk space in 'bin/../data/commitlog'. Perhaps the Cassandra user does not have the necessary permissions
        at org.apache.cassandra.config.DatabaseDescriptor.lambda$tryGetSpace$3(DatabaseDescriptor.java:1188)
        at org.apache.cassandra.io.util.PathUtils.tryOnFileStore(PathUtils.java:639)
        at org.apache.cassandra.io.util.PathUtils.tryGetSpace(PathUtils.java:665)
        at org.apache.cassandra.config.DatabaseDescriptor.tryGetSpace(DatabaseDescriptor.java:1188)
        at org.apache.cassandra.config.DatabaseDescriptor.applySimpleConfig(DatabaseDescriptor.java:553)
        at org.apache.cassandra.config.DatabaseDescriptor.applyAll(DatabaseDescriptor.java:350)
        at org.apache.cassandra.config.DatabaseDescriptor.daemonInitialization(DatabaseDescriptor.java:178)
        at org.apache.cassandra.config.DatabaseDescriptor.daemonInitialization(DatabaseDescriptor.java:162)
        at org.apache.cassandra.service.CassandraDaemon.applyConfig(CassandraDaemon.java:800)
        at org.apache.cassandra.service.CassandraDaemon.activate(CassandraDaemon.java:736)
        at org.apache.cassandra.service.CassandraDaemon.main(CassandraDaemon.java:871)

This was at least convenient for development, but also may be relied upon by some tooling/automation.

Issue Links

• is duplicated by: CASSANDRA-17115 When data dir is not present, we fail as FileNotFound causes org.apache.cassandra.config.DatabaseDescriptor#tryGetSpace to fail