[CASSANDRA-17026] UnableToParseClientMessageFromBlockedSubnetTest.badMessageCausesProtocolExceptionFromExcludeList failing on extra log entries

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.1-alpha1, 4.1
• Component/s: Observability/Logging, Test/dtest/java
• Bug Category: Correctness - Test Failure
• Severity: Low
• Complexity: Normal
• Discovered By: DTest
• Platform: All
• Since Version: 4.1

Source Control Link

https://github.com/apache/cassandra/commit/4f09733d28398207bc16ace92cda6e1ffeb99644

Test and Documentation Plan

This is a fix for a flakey test (although the fix isn't in the test itself).

• Assignee: Caleb Rackliffe
• Reporter: Caleb Rackliffe

Authors

Caleb Rackliffe

Reviewers

Jon Meredith

• Created: 07/Oct/21 21:18
• Updated: 27/May/22 19:25
• Resolved: 09/Oct/21 06:02

Description

This test, while parameterized and run more than once, expects a single log entry describing the reporting exclusion for the single query made with each parameter combination.

However, we’re seeing this:

junit.framework.AssertionFailedError: 
Expected size:<1>  but was:<2>  in:
<["DEBUG [nioEventLoopGroup-5-2] {instance:id} 2021-10-07T09:49:42,974 Excluding client exception for /127.0.0.1:56628; address contained in client_error_reporting_exclusions",
    "DEBUG [nioEventLoopGroup-5-3] {instance:id} 2021-10-07T09:49:42,984 Excluding client exception for /127.0.0.1:56634; address contained in client_error_reporting_exclusions"]>
	at org.apache.cassandra.distributed.test.UnableToParseClientMessageFromBlockedSubnetTest.badMessageCausesProtocolExceptionFromExcludeList(UnableToParseClientMessageFromBlockedSubnetTest.java:114)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

Looking at the logs more deeply, the V3 and V4 protocol cases are actually logging twice, once on initially processing the message, and again on channel closure. There should be a way to eliminate the double logging...

Issue Links

• is caused by: CASSANDRA-16859 allow blocking IPs from updating metrics about traffic