Uploaded image for project: 'Cassandra'
  1. Cassandra
  2. CASSANDRA-16975

CompactionTask#runMayThrow should not release new SSTables for offline transactions

    XMLWordPrintableJSON

Details

    • Correctness
    • Low
    • Normal
    • Code Inspection
    • All
    • None
    • NA
    • Hide

      I added a test to CompactionTaskTest that ensures that SSTables produced by offline CompactionTasks are not released.

      Show
      I added a test to CompactionTaskTest that ensures that SSTables produced by offline CompactionTasks are not released.

    Description

      Right now, CompactionTask#runMayThrow releases new SSTables for offline transactions (code). This change was added in CASSANDRA-8962, prior to the introduction of lifecycle transactions in CASSANDRA-8568. I suspect that this behavior might be undesired and could have just fallen through the cracks.

      To my knowledge, this code does not cause any known bugs solely because in-tree tools do not access the SSTables they produce before exiting. However, if someone is to write, say, offline compaction daemon, it might break on subsequent compactions because newly created SSTables will be released.

      Attachments

        Activity

          People

            Gerrrr Aleksandr Sorokoumov
            Gerrrr Aleksandr Sorokoumov
            Aleksandr Sorokoumov
            Andres de la Peña, Branimir Lambov
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: