[CASSANDRA-16975] CompactionTask#runMayThrow should not release new SSTables for offline transactions

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 3.0.26, 3.11.12, 4.0.2, 4.1-alpha1, 4.1
• Component/s: Local/Compaction
• Bug Category: Correctness
• Severity: Low
• Complexity: Normal
• Discovered By: Code Inspection
• Platform: All
• Since Version: NA

Source Control Link

https://github.com/apache/cassandra/commit/3e6faca572a5ca1de5906b39b8c0a6bf4deb40e9

Test and Documentation Plan

I added a test to CompactionTaskTest that ensures that SSTables produced by offline CompactionTasks are not released.

• Assignee: Alex Sorokoumov
• Reporter: Alex Sorokoumov

Authors

Alex Sorokoumov

Reviewers

Andres de la Peña, Branimir Lambov

• Created: 18/Sep/21 16:03
• Updated: 27/May/22 19:24
• Resolved: 30/Sep/21 12:19

Description

Right now, CompactionTask#runMayThrow releases new SSTables for offline transactions (code). This change was added in CASSANDRA-8962, prior to the introduction of lifecycle transactions in CASSANDRA-8568. I suspect that this behavior might be undesired and could have just fallen through the cracks.

To my knowledge, this code does not cause any known bugs solely because in-tree tools do not access the SSTables they produce before exiting. However, if someone is to write, say, offline compaction daemon, it might break on subsequent compactions because newly created SSTables will be released.