[CASSANDRA-16959] nodetool setstreamthroughput accepts invalid arguments that are not immediately applied

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 3.0.26, 3.11.12, 4.0.2, 4.1-alpha1, 4.1
• Component/s: Tool/nodetool
• Bug Category: Code
• Severity: Normal
• Complexity: Normal
• Discovered By: Code Inspection
• Platform: All
• Since Version: NA

Source Control Link

https://github.com/apache/cassandra/commit/4f8afe85bfb2633d98beed39e665463bf19b8789

Test and Documentation Plan

Some unit tests are included.

• Assignee: Andres de la Peña
• Reporter: Andres de la Peña

Authors

Andres de la Peña

Reviewers

Aleksei Zotov, Berenguer Blasi, Brandon Williams

• Created: 15/Sep/21 14:27
• Updated: 27/May/22 19:25
• Resolved: 01/Oct/21 11:03

Description

Both nodetool setstreamthroughput and nodetool setinterdcstreamthroughput accept a negative throughput. The throughput value is not immediately applied to the corresponding rate limiters. Instead, the value is set in the Config and it's only applied to the singleton rate limiter when new sstable stream writer are created (see here). This could happen much later than the definition of the new throughput, and by then the setting of the new rate in the rate limiter will fail with an IllegalArgumentException due to the negative value.

I think we should either immediately reject negative throughputs or consider them unlimited, as we do with zero. Also we should probably apply the new throughput to the rate limiter immediately, since I don't see why we should wait to start using the new throughput.

Issue Links

• links to: PR trunk