[CASSANDRA-16911] Remove ephemeral snapshot marker file and introduce a flag to SnapshotManifest

• Type: Improvement
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 5.0-alpha1, 5.0
• Component/s: Local/Snapshots
• Change Category: Code Clarity
• Complexity: Normal
• Platform: All

Source Control Link

https://github.com/apache/cassandra/commit/55f094a6d2c288b74e6ea86edaa7c45cd494c208

Test and Documentation Plan

unit tests

• Assignee: Stefan Miklosovic
• Reporter: Stefan Miklosovic

Authors

Stefan Miklosovic

Reviewers

Paulo Motta

• Created: 02/Sep/21 19:25
• Updated: 12/Sep/23 13:03
• Resolved: 15/Jul/22 19:39

Description

While creating an ephemeral snapshot, a marker file is created at disk in a respective snapshot directory. This is not necessary anymore as we have introduced SnapshotManifest in CASSANDRA-16789 so we can move this flag there. By putting the information if a snapshot is ephemeral or not into SnapshotManifest, we simplify and "clean up" the snapshotting process and related codebase.