[CASSANDRA-16809] Dockerise cqlshlib tests

• Type: Improvement
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 3.0.26, 3.11.12, 4.0.1, 4.1-alpha1, 4.1
• Component/s: CI, Test/dtest/python
• Change Category: Quality Assurance
• Complexity: Low Hanging Fruit
• Platform: All

Source Control Link

https://github.com/apache/cassandra-builds/commit/4431728f6483aed303362b4893c7d27118a4c841 https://github.com/apache/cassandra/commit/09c157e0f84e586193ad2bd194f4b187c7246868 https://github.com/apache/cassandra/commit/7bab2da37591ec509e541581aedfb20898aa

Test and Documentation Plan

CI (custom job on ci-cassandra.apache.org)

• Assignee: Michael Semb Wever
• Reporter: Michael Semb Wever

Authors

Michael Semb Wever

Reviewers

Berenguer Blasi, Brandon Williams

• Created: 17/Jul/21 21:05
• Updated: 10/Nov/22 13:48
• Resolved: 09/Aug/21 20:20

Description

The cqlshlib tests are the last remaining tests that don't run in docker.

Before 4.0 the cqlshlib builds are hardcoded to python2, but the test docker image doesn't support python2.

(Maybe this is why cqlshlib tests don't exist in pre 4.0 circleci?)

Dockerising the cqlshlib tests, makes it a lot easier to keep jenkins' agents clean of zombie processes.

Patches:

• cassandra-builds: https://github.com/apache/cassandra-builds/pull/50
• 3.11: https://github.com/apache/cassandra/compare/cassandra-3.11...thelastpickle:mck/dockerise-cqlsh-tests/3.11
• 3.0: https://github.com/apache/cassandra/compare/cassandra-3.0...thelastpickle:mck/dockerise-cqlsh-tests/3.0

Patches are not required for 4.0 and trunk, as the --no-site-packages flag to virtualenv has already been removed from them.

Issue Links

• causes: CASSANDRA-18028 pylib cqlsh tests fail on cython