[CASSANDRA-16728] test_tombstone_failure_threshold_message assert checking if array == string, should check for array truthiness

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: NA
• Component/s: Test/dtest/python
• Bug Category: Correctness - Test Failure
• Severity: Low
• Complexity: Low Hanging Fruit
• Discovered By: Unit Test
• Platform: All
• Since Version: NA

Source Control Link

https://github.com/apache/cassandra-dtest/commit/964051b04767689a1a3a84493c0b4afe77d6edfc

Test and Documentation Plan

tested locally

• Assignee: David Capwell
• Reporter: David Capwell

Authors

David Capwell

Reviewers

Yifan Cai

• Created: 09/Jun/21 22:59
• Updated: 10/Jun/21 00:13
• Resolved: 10/Jun/21 00:13

Description

The test pushed_notifications_test.py::TestVariousNotifications::test_tombstone_failure_threshold_message checks for the log message "Scanned over.* tombstones.* query aborted”, but this can happen on any node, so it will timeout checking node1 then check the other nodes; when this happens it checks that the returned result equals "Cannot find tombstone failure threshold error in log after failed query”, which isn’t possible as the return is matching log lines, this should be replaced by checking for failure truthiness.

Issue Links

• links to: GH: trunk