Uploaded image for project: 'Cassandra'
  1. Cassandra
  2. CASSANDRA-16575

"compression" configuration in unit tests is incorrect

Log workAgile BoardRank to TopRank to BottomAttach filesAttach ScreenshotBulk Copy AttachmentsBulk Move AttachmentsVotersWatch issueWatchersCreate sub-taskConvert to sub-taskMoveLinkCloneLabelsUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Resolved
    • Normal
    • Resolution: Fixed
    • 4.0-rc2, 4.0
    • Test/unit
    • None

    Description

      When running unit tests with "compression" configuration, we use non-default Snappy compressor.

      There is a misleading fragment of build.xml:

            <property name="compressed_yaml" value="${build.test.dir}/cassandra.compressed.yaml"/>
            <concat destfile="${compressed_yaml}">
                <fileset file="${test.conf}/cassandra.yaml"/>
                <fileset file="${test.conf}/commitlog_compression.yaml"/>
            </concat>
      

      cassandra.compressed.yaml has been replaced in CASSANDRA-14482 by two files commitlog_compression_LZ4.yaml and commitlog_compression_Zstd.yaml without changing build configuration.

      All in all we could fix that but I doubt it makes any sense since cdc configuration already uses compressed commit log anyway so it feels redundant to test compression alone for each CI run.

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            jlewandowski Jacek Lewandowski Assign to me
            jlewandowski Jacek Lewandowski
            Jacek Lewandowski
            Michael Semb Wever
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Time Tracking

              Estimated:
              Original Estimate - Not Specified
              Not Specified
              Remaining:
              Remaining Estimate - 0h
              0h
              Logged:
              Time Spent - 1.5h
              1.5h

              Slack

                Issue deployment