[CASSANDRA-16575] "compression" configuration in unit tests is incorrect

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-rc2, 4.0
• Component/s: Test/unit
• Epic Link: 40_Quality_Test
• Bug Category: Correctness - Test Failure
• Severity: Normal
• Complexity: Low Hanging Fruit
• Discovered By: User Report
• Platform: All
• Since Version: 4.0-alpha1

Source Control Link

https://github.com/apache/cassandra/commit/10a1d65eb09a93aee32948b46b4f1a0fbc2defe0

Test and Documentation Plan

CI

• Assignee: Jacek Lewandowski
• Reporter: Jacek Lewandowski

Authors

Jacek Lewandowski

Reviewers

Michael Semb Wever

• Created: 08/Apr/21 08:31
• Updated: 19/Nov/21 06:56
• Resolved: 28/Apr/21 08:51

Description

When running unit tests with "compression" configuration, we use non-default Snappy compressor.

There is a misleading fragment of build.xml:

      <property name="compressed_yaml" value="${build.test.dir}/cassandra.compressed.yaml"/>
      <concat destfile="${compressed_yaml}">
          <fileset file="${test.conf}/cassandra.yaml"/>
          <fileset file="${test.conf}/commitlog_compression.yaml"/>
      </concat>

cassandra.compressed.yaml has been replaced in CASSANDRA-14482 by two files commitlog_compression_LZ4.yaml and commitlog_compression_Zstd.yaml without changing build configuration.

All in all we could fix that but I doubt it makes any sense since cdc configuration already uses compressed commit log anyway so it feels redundant to test compression alone for each CI run.

Issue Links

• relates to: CASSANDRA-47 SSTable compression