[CASSANDRA-16279] Incorrect check for -Xlog in cassandra-env.sh

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-rc1, 4.0
• Component/s: Packaging
• Bug Category: Code
• Severity: Low
• Complexity: Low Hanging Fruit
• Discovered By: User Report
• Platform: All
• Since Version: 4.0-alpha1

Source Control Link

https://github.com/apache/cassandra/commit/023eecb03acbc3d8ad751853f7ef067220eba1e9

Test and Documentation Plan

The change is verified by uncommenting the gc log option in the respective server.options file (8, 11) and checking that the options from cassandra-ev.sh are not added if those are already present.

• Assignee: Adam Holmberg
• Reporter: Yakir Gibraltar

Authors

Adam Holmberg

Reviewers

Adam Holmberg, Michael Semb Wever

• Created: 17/Nov/20 12:59
• Updated: 10/Jan/21 14:04
• Resolved: 08/Jan/21 21:08

Description

Possible small bug in cassandra-env.sh of Cassandra 4:
https://github.com/apache/cassandra/blob/trunk/conf/cassandra-env.sh#L98
The following command incorrect:

 echo "$JVM_OPTS" | grep -q "^-[X]log:gc"

Should be:

echo "$JVM_OPTS" | grep -qe "-[X]log:gc"

The variable  $JVM_OPTS not starting with -Xlog..  , and always return 1, remove ^ and add -qe  will solve the problem.
It's causing that cassandra-env.sh  ignoring variable of -Xlog  in jvm11-server.options and jvm8-server.options

 

Right now, jvm11-server.options with:

-Xlog:gc=info,heap*=trace,age*=debug,safepoint=info,promotion*=trace:file=/var/log/cassandra/gc.log:time,uptime,pid,tid,level:filecount=10,filesize=100M

Will generate process of:

-Xlog:gc=info,heap*=trace,age*=debug,safepoint=info,promotion*=trace:file=/var/log/cassandra/gc.log:time,uptime,pid,tid,level:filecount=10,filesize=100M -Xlog:gc=info,heap*=trace,age*=debug,safepoint=info,promotion*=trace:file=/var/log/cassandra/gc.log:time,uptime,pid,tid,level:filecount=10,filesize=10485760

With fix it will generate correct gc option of :

-Xlog:gc=info,heap*=trace,age*=debug,safepoint=info,promotion*=trace:file=/var/log/cassandra/gc.log:time,uptime,pid,tid,level:filecount=10,filesize=100M