Uploaded image for project: 'Apache Cassandra'
  1. Apache Cassandra
  2. CASSANDRA-16276

Drain and/or shutdown might throw because of slow messaging service shutdown

    XMLWordPrintableJSON

Details

    • Code - Bug - Unclear Impact
    • Low
    • Low Hanging Fruit
    • User Report
    • All
    • None
    • Hide

      None needed

      Show
      None needed

    Description

      If we invoke nodetool drain before shutdown, it sometimes fails to shut down messaging service in time (in this case - timing out the shutdown of the eventloopgroup by Netty). But, not before we manage to set isShutdown of StorageService to true, despite aborting further drain logic (including shutting down mutation stages).

      Then, via on shutdown hook, we invoke drain() method again, implicitly. We see that the mutation stage is not shutdown and proceed to assert that isShutdown == false, failing that assertion and triggering a second error log message.

      The patch merely ensures that any exception thrown by MS shutdown is captured so that drain logic can complete the first time around.

      Attachments

        Activity

          People

            aleksey Aleksey Yeschenko
            aleksey Aleksey Yeschenko
            Aleksey Yeschenko
            Aleksey Yeschenko, Alex Petrov, Marcus Eriksson
            Votes:
            0 Vote for this issue
            Watchers:
            3 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: