[CASSANDRA-16179] gen-doc depends on jar

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Duplicate
• Component/s: Build, Documentation/Website
• Platform: All
• Assignee: Angelo Polo
• Reporter: Angelo Polo

Authors

Angelo Polo

• Created: 03/Oct/20 11:26
• Updated: 29/Apr/21 10:05
• Resolved: 29/Apr/21 10:05

Description

The target 'gen-doc' depends on 'jar' so let's add it the depends attribute. Patches for trunk and 3.11 are attached.

# ant gen-doc
gen-doc:
     [exec] python convert_yaml_to_rst.py ../conf/cassandra.yaml source/configuration/cassandra_config_file.rst
     [exec] python gen-nodetool-docs.py
     [exec] ls: cannot access '../bin/../build/apache-cassandra*.jar': No such file or directory
     [exec] ERROR: Nodetool failed to run, you likely need to build cassandra using ant jar from the top level directory
     [exec] Error: Could not find or load main class org.apache.cassandra.tools.NodeTool
     [exec] Makefile:64: recipe for target 'html' failed
     [exec] Traceback (most recent call last):
     [exec]   File "gen-nodetool-docs.py", line 68, in <module>
     [exec]     create_help_file()
     [exec]   File "gen-nodetool-docs.py", line 52, in create_help_file
     [exec]     raise cpe
     [exec]   File "gen-nodetool-docs.py", line 46, in create_help_file
     [exec]     subprocess.check_call([nodetool, "help"], stdout=output_file)
     [exec]   File "/usr/lib/python3.6/subprocess.py", line 311, in check_call
     [exec]     raise CalledProcessError(retcode, cmd)
     [exec] subprocess.CalledProcessError: Command '['../bin/nodetool', 'help']' returned non-zero exit status 1.
     [exec] make: *** [html] Error 1
     [exec] Result: 2

The then redundant 'jar' dependency on the 'artifacts' target could be removed too, though the attached patches don't include this modification.

Issue Links

• is fixed by: CASSANDRA-16391 Migrate dependency handling from maven-ant-tasks to resolver-ant-tasks