[CASSANDRA-16003] ToolRunner added in CASSANDRA-15942 stdErr checks improvements

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-beta2, 4.0
• Component/s: Test/unit
• Bug Category: Code - Bug - Unclear Impact
• Severity: Normal
• Complexity: Low Hanging Fruit
• Discovered By: Unit Test
• Platform: All
• Since Version: 4.0-beta1

Source Control Link

https://github.com/apache/cassandra/commit/9a23a8a6af5ab1ee8c947f363b0e32f71369746f

Test and Documentation Plan

See PR

• Assignee: Berenguer Blasi
• Reporter: David Capwell

Authors

Berenguer Blasi

Reviewers

David Capwell

• Created: 30/Jul/20 22:10
• Updated: 03/Jan/21 17:03
• Resolved: 06/Aug/20 16:26

Description

The JVM will output to stderr on some environments to show what flags that were picked up, when this happens all tests which validate stderr start to fail. This was found in the org.apache.cassandra.tools.ClearSnapshotTest as it switched to use the ToolRunner; below is a sample failure on my laptop (I had to modify the asserts since they don’t include the input)

java.lang.AssertionError: 
Expecting empty but was:<"Picked up _JAVA_OPTIONS: -Djava.net.preferIPv4Stack=true
">

	at org.apache.cassandra.tools.ToolRunner.assertEmptyStdErr(ToolRunner.java:339)
	at org.apache.cassandra.tools.ToolRunner.waitAndAssertOnCleanExit(ToolRunner.java:334)
	at org.apache.cassandra.tools.ClearSnapshotTest.testClearSnapshot_RemoveMultiple(ClearSnapshotTest.java:91)

Here _JAVA_OPTIONS is used globally on my system so fails the test; there is also JAVA_TOOL_RUNNER which is used the same way.

Issue Links

• Is contained by: CASSANDRA-15583 4.0 quality testing: Tooling, Bundled and First Party
• is related to: CASSANDRA-15942 15583 - Tooling testing foundation
• links to: CASSANDRA-16003 PR