[CASSANDRA-15920] SimpleQueryResult should contain client warnings

• Type: Improvement
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-beta1, 4.0
• Component/s: Test/dtest/java
• Labels: pull-request-available
• Change Category: Quality Assurance
• Complexity: Normal
• Platform: All

Source Control Link

https://github.com/apache/cassandra-in-jvm-dtest-api/commit/327c5980b21b1d7c47e0935ef5cb0c0c4c90d3ed

Test and Documentation Plan

Additional cases in QueryResultTest to ensure that warnings behave as expected, even w/ delegation.

• Assignee: Caleb Rackliffe
• Reporter: Caleb Rackliffe

Authors

Caleb Rackliffe

Reviewers

Alex Petrov, David Capwell

• Created: 02/Jul/20 23:18
• Updated: 21/Dec/20 09:32
• Resolved: 13/Jul/20 04:01

Description

There isn't a way to get query warnings generated via ClientWarn using the existing ICoordinator interface. The simplest possible change here would be to...

1.) Make sure we activate warning collection before queries start.

2.) Rip warnings out of ClientWarn when queries return.

3.) Include those warnings when we create SimpleQueryResult.

QueryResult might not need to expose the warnings, given not all its implementations would be expected to have them, but we could just return an empty list of warnings by default.

Issue Links

• relates to: CASSANDRA-15907 Operational Improvements & Hardening for Replica Filtering Protection
• links to: GitHub Pull Request #12