[CASSANDRA-15787] CQLSH doesn't exit with proper code with multiple SOURCE directives.

• Type: Bug
• Status: Triage Needed
• Priority: Normal
• Resolution: Unresolved
• Component/s: Tool/cqlsh
• Platform: All
• Assignee: Kaden Luke Nelson
• Reporter: Kaden Luke Nelson

Authors

Kaden Luke Nelson

• Created: 04/May/20 20:46
• Updated: 04/May/20 20:46

Description

When I have the following files;

 

# master.sql

CREATE TABLE asdf (  id text,  primary key (id));

# a.sql

SOURCE './master.sql';

CREATE TABLE asdf (  id text,  primary key (id));

# b.sql

SOURCE './a.sql';

 
and execute

cqlsh --keyspace example --file ./b.sql

 

I don't get returned the proper status code. This happens because when multiple SOURCE commands are chained together like in the example above, the error doesn't get passed through to the final 'shell'. 

 

Subshell that needs to pass the statement error value to the parent shell: https://github.com/apache/cassandra/blob/trunk/bin/cqlsh.py#L1776
final statement error check which returns the parent shell statement error: https://github.com/apache/cassandra/blob/trunk/bin/cqlsh.py#L2474