[CASSANDRA-15727] Internode messaging connection setup between 4.0 and legacy SSL 3.0 fails if initial connection version incorrect

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-beta1, 4.0
• Component/s: Messaging/Internode
• Labels: pull-request-available
• Bug Category: Availability - Unavailable
• Severity: Normal
• Complexity: Low Hanging Fruit
• Discovered By: Adhoc Test
• Platform: All
• Since Version: 4.0-alpha

Source Control Link

678ca3fc29c38b64a110dcf40693aa7840b0585c

Test and Documentation Plan

Reproduced in ConnectionTest. testPendingOutboundConnectionUpdatesMessageVersionOnReconnectAttempt and checked the fix.

• Assignee: Jon Meredith
• Reporter: Jon Meredith

Authors

Andy Tolbert, Jon Meredith

Reviewers

Aleksey Yeschenko

• Created: 15/Apr/20 03:06
• Updated: 12/Feb/21 17:08
• Resolved: 13/May/20 15:36

Description

This was discovered while testing upgrading an SSL enabled cluster from 3.0 to 4.0. The 3.0 cluster was configured to only listen on the ssl storage port. When the upgraded 4.0 node started it received a gossip messsage that triggered a shadow round before it had correctly set the messaging versions for the other endpoints.

Sending the message created the connection, but because the endpoint defaulted to VERSION_40 the initial connect attempt was to the regular storage_port. The 3.0 node was only listening on the ssl_storage_port, so the connection was refused and the OutboundConnection.onFailure handler was called. As the shadow
gossip round had queued up a message, the hasPending branch was followed and the connection was rescheduled, however the port is never recalculated as the original settings are used so it always fails.

Meanwhile, the node discovered information about peers through inbound connection and gossip updating the messaging version for the endpoint which could have been used to make a valid connection.

Issue Links

• duplicates: CASSANDRA-14848 When upgrading 3.11.3->4.0 using SSL 4.0 nodes does not connect to old non seed nodes
• links to: GitHub Pull Request #538