[CASSANDRA-15636] Refactor protocol related code to eliminate magic numbers

• Type: Improvement
• Status: Open
• Priority: Low
• Resolution: Unresolved
• Component/s: Messaging/Client
• Change Category: Code Clarity
• Complexity: Low Hanging Fruit
• Platform: All
• Assignee: Dinesh Joshi
• Reporter: Dinesh Joshi

Authors

Dinesh Joshi

• Created: 11/Mar/20 17:29
• Updated: 18/May/20 19:33

Description

Parts of Cassandra's codebase has protocol related magic numbers. It makes the code hard to understand. We should refactor the code to remove magic numbers and instead replace them with versioned constants. This will help make the code clearer. Example: https://github.com/apache/cassandra/blob/trunk/src/java/org/apache/cassandra/transport/messages/ErrorMessage.java#L288