[CASSANDRA-15612] Mutating sstable metadata during anticompaction fails silently on legacy sstables

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0, 4.0-alpha4
• Component/s: Consistency/Repair
• Bug Category: Correctness - Recoverable Corruption / Loss
• Severity: Low
• Complexity: Low Hanging Fruit
• Discovered By: Code Inspection
• Platform: All
• Since Version: 4.0-alpha

Source Control Link

https://github.com/apache/cassandra/commit/579c9ab311e9efcbc3329599232a8f9992b2694e

Test and Documentation Plan

new legacy sstable test and cci runs

• Assignee: Marcus Eriksson
• Reporter: Marcus Eriksson

Authors

Marcus Eriksson

Reviewers

Benjamin Lerer

• Created: 02/Mar/20 10:06
• Updated: 15/May/20 08:55
• Resolved: 09/Apr/20 14:48

Description

If there is an sstable with a version without pending repair information included in an incremental repair we silently don't set the pending repair correctly. We should fail the IR instead.