[CASSANDRA-15551] Fix flaky tests org.apache.cassandra.service.MoveTest testStateJumpToNormal and testMoveWithPendingRangesNetworkStrategyRackAwareThirtyNodes

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-alpha4, 4.0
• Component/s: Test/unit
• Labels: pull-request-available
• Bug Category: Correctness - Test Failure
• Severity: Normal
• Complexity: Normal
• Discovered By: Unit Test
• Platform: All
• Since Version: 4.0-alpha

Source Control Link

https://github.com/apache/cassandra/commit/2344e77c026f1ecfed4f9ba84dab21ede2cf5b26

Test and Documentation Plan

For testing, check the reproduction steps in my comment below and verify that with the patch, the main thread waits while the endpoints are being evicted, before running another test method.
Unit tests results attached for both Java 11 and 8.
Since this is a change only in the test realm, no further documentation is required.

• Assignee: Gianluca Righetto
• Reporter: David Capwell

Authors

Gianluca Righetto

Reviewers

Brandon Williams

• Created: 05/Feb/20 19:00
• Updated: 16/Mar/22 13:21
• Resolved: 10/Apr/20 16:34

Description

testStateJumpToNormal failure was on java 11

java.lang.NullPointerException
	at org.apache.cassandra.gms.Gossiper.getHostId(Gossiper.java:1028)
	at org.apache.cassandra.gms.Gossiper.getHostId(Gossiper.java:1023)
	at org.apache.cassandra.service.StorageService.handleStateNormal(StorageService.java:2513)
	at org.apache.cassandra.service.StorageService.onChange(StorageService.java:2055)
	at org.apache.cassandra.Util.createInitialRing(Util.java:225)
	at org.apache.cassandra.service.MoveTest.testStateJumpToNormal(MoveTest.java:935)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)

testMoveWithPendingRangesNetworkStrategyRackAwareThirtyNodes failure was on java 8

java.lang.NullPointerException
	at org.apache.cassandra.service.StorageService.updatePeerInfo(StorageService.java:2174)
	at org.apache.cassandra.service.StorageService.handleStateNormal(StorageService.java:2511)
	at org.apache.cassandra.service.StorageService.onChange(StorageService.java:2055)
	at org.apache.cassandra.Util.createInitialRing(Util.java:225)
	at org.apache.cassandra.service.MoveTest.testMoveWithPendingRangesNetworkStrategyRackAwareThirtyNodes(MoveTest.java:199)

Issue Links

• links to: GitHub Pull Request #533