[CASSANDRA-15507] Test org.apache.cassandra.distributed.test.DistributedReadWritePathTest#failingReadRepairTest does not test a failing read repair and should be updated to actually trigger a failed read repair

• Type: Bug
• Status: Resolved
• Priority: Normal
• Resolution: Fixed
• Fix Version/s: 4.0-alpha3, 4.0
• Component/s: Test/unit
• Labels: pull-request-available
• Bug Category: Correctness - Test Failure
• Severity: Normal
• Complexity: Low Hanging Fruit
• Discovered By: Code Inspection
• Platform: All
• Since Version: 4.0

Source Control Link

https://github.com/apache/cassandra/commit/815c397f4876aae9ed2ae5a9578c5ec7087643ab

Test and Documentation Plan

PR: https://github.com/apache/cassandra/pull/424

CircleCI: https://circleci.com/gh/dcapwell/cassandra/tree/fixDistributedReadWritePathTestTest

• Assignee: David Capwell
• Reporter: David Capwell

Authors

David Capwell

Reviewers

Alex Petrov

• Created: 15/Jan/20 21:52
• Updated: 15/May/20 08:39
• Resolved: 17/Jan/20 13:50

Description

The test org.apache.cassandra.distributed.test.DistributedReadWritePathTest#failingReadRepairTest makes a few assumptions which are not valid at the moment.

1) the write to node 1 and 2 have the same digest (they don’t, this is caused by the timestamp being different)
2) node 3 will participate with the read; it won’t give the fact that org.apache.cassandra.locator.ReplicaPlans#contactForRead will speculate the first 2 nodes always, so node 3 won’t get involved with the repair
3) node 3 will attempt to get repaired (it won’t because its never looked at)

Issue Links

• links to: GitHub Pull Request #424